Skip to content

8338103: Stabilize and open source a Swing OGL ButtonResizeTest#2869

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8338103-V21
Open

8338103: Stabilize and open source a Swing OGL ButtonResizeTest#2869
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8338103-V21

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Apr 17, 2026

Backporting JDK-8338103: Stabilize and open source a Swing OGL ButtonResizeTest.

This PR adds a new headful test that checks Swing JButton rendering when resized.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java

Results attached:

windows-x64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
macos-aarch64-specific-test.log

Please note that test failed in macOS. Flakiness identified in JDK-8339233 (Dependent PR #2870).

Reran on macos-aarch64:

../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java

Results:

test result: Passed. Execution successful

SwingButtonResizeTestWithOpenGL_id0.jtr.txt

test result: Passed. Execution successful

SwingButtonResizeTestWithOpenGL_id3.jtr.txt



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338103 needs maintainer approval

Issue

  • JDK-8338103: Stabilize and open source a Swing OGL ButtonResizeTest (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2869/head:pull/2869
$ git checkout pull/2869

Update a local copy of the PR:
$ git checkout pull/2869
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2869

View PR using the GUI difftool:
$ git pr show -t 2869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2869.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 3d49fb8a17ceec6e23595bc8affc89765899f72b 8338103: Stabilize and open source a Swing OGL ButtonResizeTest Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 17, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review April 17, 2026 17:00
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 17, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 17, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 20, 2026

/approval request for backport of JDK-8338103: Stabilize and open source a Swing OGL ButtonResizeTest.

This is a test addition.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

@rm-gh-8
8338103: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant