8338103: Stabilize and open source a Swing OGL ButtonResizeTest#2869
8338103: Stabilize and open source a Swing OGL ButtonResizeTest#2869rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8338103: Stabilize and open source a Swing OGL ButtonResizeTest. This is a test addition. For parity with Oracle JDK. |
Backporting JDK-8338103: Stabilize and open source a Swing OGL ButtonResizeTest.
This PR adds a new headful test that checks Swing JButton rendering when resized.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java
Results attached:
windows-x64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
macos-aarch64-specific-test.log
Please note that test failed in macOS. Flakiness identified in JDK-8339233 (Dependent PR #2870).
Reran on macos-aarch64:
../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.javaResults:
test result: Passed. Execution successfulSwingButtonResizeTestWithOpenGL_id0.jtr.txt
test result: Passed. Execution successfulSwingButtonResizeTestWithOpenGL_id3.jtr.txt
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2869/head:pull/2869$ git checkout pull/2869Update a local copy of the PR:
$ git checkout pull/2869$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2869/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2869View PR using the GUI difftool:
$ git pr show -t 2869Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2869.diff
Using Webrev
Link to Webrev Comment