8347836: Disabled PopupMenu shows shortcuts on Mac#2868
8347836: Disabled PopupMenu shows shortcuts on Mac#2868rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8347836: Disabled PopupMenu shows shortcuts on Mac. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8347836: Disabled PopupMenu shows shortcuts on Mac.
This PR fixes a false manual test failure on macOS by updating the verification steps. macOS natively shows shortcuts on disabled popup menu items.
For parity with Oracle JDK.
Ran related test on macos-aarch64:
../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/PopupMenu/PopupMenuVisuals.javaScreenshot:
Results:
test result: Passed. Execution successfulPopupMenuVisuals.jtr.txt
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2868/head:pull/2868$ git checkout pull/2868Update a local copy of the PR:
$ git checkout pull/2868$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2868/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2868View PR using the GUI difftool:
$ git pr show -t 2868Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2868.diff
Using Webrev
Link to Webrev Comment