Skip to content

8347836: Disabled PopupMenu shows shortcuts on Mac#2868

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8347836-V21
Open

8347836: Disabled PopupMenu shows shortcuts on Mac#2868
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8347836-V21

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Apr 17, 2026

Backporting JDK-8347836: Disabled PopupMenu shows shortcuts on Mac.

This PR fixes a false manual test failure on macOS by updating the verification steps. macOS natively shows shortcuts on disabled popup menu items.

For parity with Oracle JDK.

Ran related test on macos-aarch64:

../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java

Screenshot:

Screenshot 2026-04-17 at 7 25 50 AM

Results:

test result: Passed. Execution successful

PopupMenuVisuals.jtr.txt



Progress

  • JDK-8347836 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347836: Disabled PopupMenu shows shortcuts on Mac (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2868/head:pull/2868
$ git checkout pull/2868

Update a local copy of the PR:
$ git checkout pull/2868
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2868

View PR using the GUI difftool:
$ git pr show -t 2868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2868.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347836: Disabled PopupMenu shows shortcuts on Mac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 379c3f99665829c5d8c373d1fb324dc7ef4d84cf 8347836: Disabled PopupMenu shows shortcuts on Mac Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 17, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review April 17, 2026 14:28
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 17, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 17, 2026

/approval request for backport of JDK-8347836: Disabled PopupMenu shows shortcuts on Mac.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@rm-gh-8
8347836: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 17, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 17, 2026

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant