Skip to content

8352685: Opensource JInternalFrame tests - series2#2864

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8352685-V21
Open

8352685: Opensource JInternalFrame tests - series2#2864
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8352685-V21

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Apr 16, 2026

Backporting JDK-8352685: Opensource JInternalFrame tests - series2.

This PR introduces new JInternalFrame related tests.

For parity with Oracle JDK.

The "test/jdk/javax/swing/JInternalFrame/bug4134077.java" test requires Windows, but is in the problem list for "windows-all".

Ran related test on macos-aarch64:

../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/javax/swing/JInternalFrame/bug4130806.java

Screenshot:

Screenshot 2026-04-16 at 10 47 54 AM

Results:

test result: Passed. Execution successful

bug4130806.jtr.txt

../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/javax/swing/JInternalFrame/bug4225701.java

Screenshot:

Screenshot 2026-04-16 at 10 52 46 AM

Results:

test result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Failure Reason: Used Cmd + W on a Mac, which is the Mac equivalent of Ctrl+F4 on Windows, and it didn't close.

bug4225701.jtr.txt

Please note that this is a manual test, so it wouldn't be a blocker to include. This may be a valid issue on the JDK.

Ran related test on linux-x64:

../jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/linux-x86_64-server-release/images/test/jdk/jtreg/native -jdk build/linux-x86_64-server-release/images/jdk -m test/jdk/javax/swing/JInternalFrame/bug4193070.java

Screenshot:

Screenshot 2026-04-16 at 10 59 46 AM

Results:

test result: Passed. Execution successful

bug4193070.jtr.txt



Progress

  • Change must not contain extraneous whitespace
  • JDK-8352685 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8352685: Opensource JInternalFrame tests - series2 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2864/head:pull/2864
$ git checkout pull/2864

Update a local copy of the PR:
$ git checkout pull/2864
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2864

View PR using the GUI difftool:
$ git pr show -t 2864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2864.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352685: Opensource JInternalFrame tests - series2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport da3bb06797f9550d204b2623481ef757ae941bbd 8352685: Opensource JInternalFrame tests - series2 Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 16, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review April 16, 2026 18:04
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 16, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 16, 2026

/approval request for backport of JDK-8352685: Opensource JInternalFrame tests - series2.

These are test additions.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@rm-gh-8
8352685: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 16, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 16, 2026

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant