Skip to content

8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage#2853

Open
jyma22 wants to merge 1 commit intoopenjdk:masterfrom
jyma22:JDK-8381670-ctw-gc-improv-2
Open

8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage#2853
jyma22 wants to merge 1 commit intoopenjdk:masterfrom
jyma22:JDK-8381670-ctw-gc-improv-2

Conversation

@jyma22
Copy link
Copy Markdown

@jyma22 jyma22 commented Apr 15, 2026

Backporting JDK-8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage.
This reverts commit fcbf863f4b7 due to performance regression in GZIPInputStream.
Tested on x64 with make test TEST=test/jdk/java/util/zip/GZIP



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8381670 needs maintainer approval
  • Change requires CSR request JDK-8381671 to be approved

Issues

  • JDK-8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage (Bug - P3 - Requested)
  • JDK-8381671: Revert the changes to GZIPInputStream related to InputStream.available() usage (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2853/head:pull/2853
$ git checkout pull/2853

Update a local copy of the PR:
$ git checkout pull/2853
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2853

View PR using the GUI difftool:
$ git pr show -t 2853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2853.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 15, 2026

👋 Welcome back jyma22! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 15, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 15, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 15, 2026

Webrevs

@jyma22 jyma22 changed the title 8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage Backport 51cd741573330352fc7b7395b1c8aeca8a4bdcf5 Apr 16, 2026
@jyma22
Copy link
Copy Markdown
Author

jyma22 commented Apr 16, 2026

/approval request for backport of JDK-8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage. This fixes a performance regression in GZIPInputStream and the CSR was approved. This pull request is not clean because the tip reverted 2 commits and only one needed to be reverted in 21

@openjdk openjdk Bot changed the title Backport 51cd741573330352fc7b7395b1c8aeca8a4bdcf5 8381670: Revert the changes to GZIPInputStream related to InputStream.available() usage Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@jyma22
8381670: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant