Skip to content

8380565: PPC64: deoptimization stub should save vector registers#2771

Open
TheRealMDoerr wants to merge 2 commits intoopenjdk:masterfrom
TheRealMDoerr:8380565_PPC64_deopt_VectorRegisters
Open

8380565: PPC64: deoptimization stub should save vector registers#2771
TheRealMDoerr wants to merge 2 commits intoopenjdk:masterfrom
TheRealMDoerr:8380565_PPC64_deopt_VectorRegisters

Conversation

@TheRealMDoerr
Copy link
Copy Markdown
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 30, 2026

Backport of JDK-8380565 + testfix JDK-8381315.

Most of it applies cleanly, but I had to make small adaptations because JDK-8354650 and JDK-8351666 are not in jdk21u (and not really backport candidates because they are large and require follow-up changes): VectorSRegisters are used in sharedRuntime_ppc.cpp‎. The upstream version only uses VectorRegisters.

The included regression test fails without this fix and passes with this fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8380565 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8381315 needs maintainer approval

Issues

  • JDK-8380565: PPC64: deoptimization stub should save vector registers (Bug - P3 - Requested)
  • JDK-8381315: compiler/vectorapi/TestVectorReallocation.java fails with -XX:UseAVX=1 after JDK-8380565 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2771/head:pull/2771
$ git checkout pull/2771

Update a local copy of the PR:
$ git checkout pull/2771
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2771

View PR using the GUI difftool:
$ git pr show -t 2771

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2771.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 30, 2026

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 30, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 29e1ee2eccd59e665827e0d42c490261002cf99e 8380565: PPC64: deoptimization stub should save vector registers Mar 30, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 30, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 30, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 30, 2026

Webrevs

Copy link
Copy Markdown
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cheers, Richard.

@TheRealMDoerr
Copy link
Copy Markdown
Contributor Author

Thanks for the review!

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 30, 2026

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Copy Markdown
Contributor Author

/issue add JDK-8381315

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 31, 2026

@TheRealMDoerr
Adding additional issue to issue list: 8381315: compiler/vectorapi/TestVectorReallocation.java fails with -XX:UseAVX=1 after JDK-8380565.

@openjdk openjdk Bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Apr 10, 2026
@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants