Skip to content

8373716: Refactor further java/util tests from TestNG to JUnit#2655

Draft
0zzy0sbourne wants to merge 1 commit intoopenjdk:masterfrom
0zzy0sbourne:JDK-backport-8373716
Draft

8373716: Refactor further java/util tests from TestNG to JUnit#2655
0zzy0sbourne wants to merge 1 commit intoopenjdk:masterfrom
0zzy0sbourne:JDK-backport-8373716

Conversation

@0zzy0sbourne
Copy link
Copy Markdown

@0zzy0sbourne 0zzy0sbourne commented Mar 5, 2026

Backporting JDK-8373716: Refactor further java/util tests from TestNG to JUnit

This PR backports the migration of 14 test files across java.util.Calendar, java.util.TimeZone,
java.util.Properties, and java.util.ResourceBundle from TestNG to JUnit Jupiter, as part of the broader
JDK-8307843 effort to standardize the JDK test suite on JUnit.

make test TEST=test/jdk/java/util/Calendar/CalendarDisplayNamesTest.java
make test TEST=test/jdk/java/util/Calendar/JapaneseLenientEraTest.java
make test TEST=test/jdk/java/util/Calendar/SupplementalJapaneseEraTestRun.java
make test TEST=test/jdk/java/util/Properties/CompatibilityTest.java
make test TEST=test/jdk/java/util/Properties/EncodingTest.java
make test TEST=test/jdk/java/util/Properties/InitialCapacity.java
make test TEST=test/jdk/java/util/Properties/PropertiesEntrySetTest.java
make test TEST=test/jdk/java/util/Properties/PropertiesStoreTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/basic/BasicTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/cache/CacheTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/casesensitive/CaseInsensitiveNameClash.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/visibility/VisibilityTest.java
make test TEST=test/jdk/java/util/TimeZone/NegativeDSTTest.java
make test TEST=test/jdk/java/util/TimeZone/ZoneIdRoundTripTest.java

Results:
TEST SUCCESS — 14/14 passed, 0 failures, 0 errors


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8373716 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373716: Refactor further java/util tests from TestNG to JUnit (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2655/head:pull/2655
$ git checkout pull/2655

Update a local copy of the PR:
$ git checkout pull/2655
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2655

View PR using the GUI difftool:
$ git pr show -t 2655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2655.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 5, 2026

👋 Welcome back 0zzy0sbourne! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 4e05748f0899cabb235c71ecdf4256d4ad137a0d 8373716: Refactor further java/util tests from TestNG to JUnit Mar 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 5, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Mar 5, 2026
@0zzy0sbourne 0zzy0sbourne reopened this Mar 5, 2026
@0zzy0sbourne 0zzy0sbourne force-pushed the JDK-backport-8373716 branch from e8a89da to 5bd8ec9 Compare March 5, 2026 16:35
@0zzy0sbourne
Copy link
Copy Markdown
Author

/test

@0zzy0sbourne
Copy link
Copy Markdown
Author

0zzy0sbourne commented Mar 6, 2026

Based on the CI logs, the reason for failures in windows-aarch64 and windows-x64 builds seems like unrelated to this backport, both failing during the hotspot build phase before any test code is involved:

  • windows-aarch64: segfault in fixpath.sh during adlc execution
  • windows-x64: gawk regex error in JvmMapfile.gmk during jvm.dll symbol generation

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant