Skip to content

8336342: Fix known X11 library locations in sysroot#3143

Open
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8336342-x11-sysroot
Open

8336342: Fix known X11 library locations in sysroot#3143
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8336342-x11-sysroot

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jan 30, 2026

Now that 11u GHA is working, it is time to complete this backport. I have been using this patch to build JDK 11 binaries for about a year now.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336342 needs maintainer approval

Issue

  • JDK-8336342: Fix known X11 library locations in sysroot (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3143/head:pull/3143
$ git checkout pull/3143

Update a local copy of the PR:
$ git checkout pull/3143
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3143

View PR using the GUI difftool:
$ git pr show -t 3143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3143.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ee365d75cca6f33e5781fe514e557caba2b67c32 8336342: Fix known X11 library locations in sysroot Jan 30, 2026
@openjdk
Copy link

openjdk bot commented Jan 30, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 30, 2026
@openjdk
Copy link

openjdk bot commented Jan 30, 2026

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2026

Webrevs

@shipilev
Copy link
Member Author

GHA failure looks environmental.

@shipilev
Copy link
Member Author

/approval request Fixes a simple bug in current auto-detection code. Patch is simple and applies cleanly. It was tested for about a year in my own downstream. This also matches what other JDK releases are doing. Risk is low: build fix, only realistically affects cross-compilations.

@openjdk
Copy link

openjdk bot commented Jan 30, 2026

@shipilev
8336342: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant