8384636: Parallel: Remove redundant PSAdjustTask claim counter initialization loop#31175
8384636: Parallel: Remove redundant PSAdjustTask claim counter initialization loop#31175albertnetymk wants to merge 1 commit into
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
PSAdjustTask currently initializes
_claim_counterswith a placement-new loop in the constructor body. The array elements are already constructed before the constructor body runs, and this is sufficient because the default constructor ofAtomic<uint>initializes the value to zero.This trivial patch removes the redundant loop and adds an explicit
_claim_counters{}member initializer.The generated release assembly is not byte-identical: the new form uses a vector zero store for the counter array instead of separate scalar stores. The effective initialization is the same.
Test: tier1
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31175/head:pull/31175$ git checkout pull/31175Update a local copy of the PR:
$ git checkout pull/31175$ git pull https://git.openjdk.org/jdk.git pull/31175/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31175View PR using the GUI difftool:
$ git pr show -t 31175Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31175.diff
Using Webrev
Link to Webrev Comment