Skip to content

8382627: Shenandoah: assert(old_reserve_result + young_reserve_result <= old_available + young_available) failed#31166

Open
kdnilsen wants to merge 2 commits into
openjdk:masterfrom
kdnilsen:fix-assert-for-global-gc
Open

8382627: Shenandoah: assert(old_reserve_result + young_reserve_result <= old_available + young_available) failed#31166
kdnilsen wants to merge 2 commits into
openjdk:masterfrom
kdnilsen:fix-assert-for-global-gc

Conversation

@kdnilsen
Copy link
Copy Markdown
Contributor

@kdnilsen kdnilsen commented May 14, 2026

Reset evacuation at the start of an abbreviated cycle. These values are normally set by choose_collection_set_from_regiondata(). If we don't choose a collection set, these hold non-sensical values that may result in an assertion failure.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382627: Shenandoah: assert(old_reserve_result + young_reserve_result <= old_available + young_available) failed (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31166/head:pull/31166
$ git checkout pull/31166

Update a local copy of the PR:
$ git checkout pull/31166
$ git pull https://git.openjdk.org/jdk.git pull/31166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31166

View PR using the GUI difftool:
$ git pr show -t 31166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31166.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 14, 2026

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 14, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 14, 2026

@kdnilsen The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 14, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 14, 2026

Webrevs

Comment on lines 33 to 34
#include "gc/shenandoah/shenandoahYoungGeneration.hpp"
#include "gc/shenandoah/shenandoahTrace.hpp"
Copy link
Copy Markdown

@pengxiaolong pengxiaolong May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be header order issue here, shenandoahYoungGeneration.hpp should be placed after shenandoahTrace.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants