Skip to content

8384602: Remove AppContext from java.awt.Component - #31164

Closed
prrace wants to merge 1 commit into
openjdk:masterfrom
prrace:ac_component
Closed

8384602: Remove AppContext from java.awt.Component#31164
prrace wants to merge 1 commit into
openjdk:masterfrom
prrace:ac_component

Conversation

@prrace

@prrace prrace commented May 14, 2026

Copy link
Copy Markdown
Contributor

Remove AppContext from java.awt.Component.
This allowed me to also remove the accessor for it and therefore the few remaining uses of the Accessor
No tests failed as a result of this change.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8384602: Remove AppContext from java.awt.Component (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31164/head:pull/31164
$ git checkout pull/31164

Update a local copy of the PR:
$ git checkout pull/31164
$ git pull https://git.openjdk.org/jdk.git pull/31164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31164

View PR using the GUI difftool:
$ git pr show -t 31164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31164.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 14, 2026

Copy link
Copy Markdown

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 14, 2026

Copy link
Copy Markdown

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384602: Remove AppContext from java.awt.Component

Reviewed-by: azvegint, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8384602 8384602: Remove AppContext from java.awt.Component May 14, 2026
@openjdk openjdk Bot added client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 14, 2026
@openjdk

openjdk Bot commented May 14, 2026

Copy link
Copy Markdown

@prrace The following labels will be automatically applied to this pull request:

  • client
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented May 14, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 14, 2026
@mlbridge

mlbridge Bot commented May 14, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 15, 2026
@prrace

prrace commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented May 15, 2026

Copy link
Copy Markdown

Going to push as commit 35913b8.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 15, 2026
@openjdk openjdk Bot closed this May 15, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2026
@openjdk

openjdk Bot commented May 15, 2026

Copy link
Copy Markdown

@prrace Pushed as commit 35913b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants