Skip to content

Conversation

@rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Dec 18, 2025

Hi all,

This pull request contains a backport of commit ad29642d from the openjdk/jdk repository.

The commit being backported was authored by Roland Westrelin on 15 Dec 2025 and was reviewed by Roberto Castañeda Lozano and Emanuel Peter.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351889: C2 crash: assertion failed: Base pointers must match (addp 344) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28893/head:pull/28893
$ git checkout pull/28893

Update a local copy of the PR:
$ git checkout pull/28893
$ git pull https://git.openjdk.org/jdk.git pull/28893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28893

View PR using the GUI difftool:
$ git pr show -t 28893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28893.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2025

👋 Welcome back roland! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351889: C2 crash: assertion failed:  Base pointers must match (addp 344)

Reviewed-by: rcastanedalo, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the jdk26 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ad29642d8f4e8e0fb1223b14b85ab7841d7b1b51 8351889: C2 crash: assertion failed: Base pointers must match (addp 344) Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot [email protected] labels Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2025

Webrevs

@robcasloz
Copy link
Contributor

Running internal tests, will come back with results.

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results look good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2025
@rwestrel
Copy link
Contributor Author

rwestrel commented Jan 5, 2026

@robcasloz thanks for testing and approval. I merge with latest. Do you need to rerun testing?

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roberto is still on vacation. I think we are good here. Ship it!

@rwestrel
Copy link
Contributor Author

rwestrel commented Jan 9, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2026

Going to push as commit e0f1c3a.
Since your change was applied there have been 16 commits pushed to the jdk26 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2026
@openjdk openjdk bot closed this Jan 9, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2026
@openjdk
Copy link

openjdk bot commented Jan 9, 2026

@rwestrel Pushed as commit e0f1c3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants