oh-canvas-item: Make content use 100% height and align vertical centered#3859
oh-canvas-item: Make content use 100% height and align vertical centered#3859florian-h05 wants to merge 2 commits intoopenhab:mainfrom
Conversation
… content Signed-off-by: Florian Hotze <[email protected]>
#4757 Bundle Size — 12.86MiB (~+0.01%).b49fa93(current) vs 5f8928d main#4756(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #4757 |
Baseline #4756 |
|
|---|---|---|
3.23MiB |
3.23MiB |
|
0B |
0B |
|
8.49% |
8.49% |
|
592 |
592 |
|
669 |
669 |
|
2601 |
2601 |
|
0 |
0 |
|
0% |
0% |
|
123 |
123 |
|
1 |
1 |
Bundle size by type
1 change
1 regression
| Current #4757 |
Baseline #4756 |
|
|---|---|---|
11.14MiB |
11.14MiB |
|
896.45KiB (+0.1%) |
895.58KiB |
|
526.1KiB |
526.1KiB |
|
295.6KiB |
295.6KiB |
|
45.73KiB |
45.73KiB |
|
847B |
847B |
Bundle analysis report Branch florian-h05:canvas-alignment Project dashboard
Generated by RelativeCI Documentation Report issue
|
@JustinGeorgi @hmerk @stefan-hoehn WDYT? I think the change makes canvas bevave correctly, but I am neither actively using it nor want to break existing canvas. |
|
I have never used the canvas for anything significant, so I'm in the same situation. I think this looks like a good change but, I can't say if it will be problematic. |
|
Used canvas layout for the demo case only, so not really having much experience with it. |
|
Here is my comment from the community post to continue discussion here:
|
|
@florian-h05 - just confirming this is no longer draft (as stated in the initial comment). |
|
Let's undraft and merge this, we are far away from 5.2.0 so we have enough time to test this and revert in case it was a bad idea. |




Related to https://community.openhab.org/t/vertical-alignment-of-standard-library-widgets-in-fixed-canvas-layout/168211.