Skip to content

oh-canvas-item: Make content use 100% height and align vertical centered#3859

Open
florian-h05 wants to merge 2 commits intoopenhab:mainfrom
florian-h05:canvas-alignment
Open

oh-canvas-item: Make content use 100% height and align vertical centered#3859
florian-h05 wants to merge 2 commits intoopenhab:mainfrom
florian-h05:canvas-alignment

Conversation

@florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Feb 7, 2026

@florian-h05
Copy link
Contributor Author

florian-h05 commented Feb 7, 2026

Before:

image image

After:

Note how the NULL value is properly aligned and the widget takes up the full frame.

image image

@relativeci
Copy link

relativeci bot commented Feb 7, 2026

#4757 Bundle Size — 12.86MiB (~+0.01%).

b49fa93(current) vs 5f8928d main#4756(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#4757
     Baseline
#4756
No change  Initial JS 3.23MiB 3.23MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 8.49% 8.49%
No change  Chunks 592 592
No change  Assets 669 669
No change  Modules 2601 2601
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 123 123
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#4757
     Baseline
#4756
No change  JS 11.14MiB 11.14MiB
Regression  CSS 896.45KiB (+0.1%) 895.58KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 45.73KiB 45.73KiB
No change  Other 847B 847B

Bundle analysis reportBranch florian-h05:canvas-alignmentProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05
Copy link
Contributor Author

@JustinGeorgi @hmerk @stefan-hoehn WDYT? I think the change makes canvas bevave correctly, but I am neither actively using it nor want to break existing canvas.

@florian-h05 florian-h05 added main ui Main UI labels Feb 7, 2026
@JustinGeorgi
Copy link
Contributor

I have never used the canvas for anything significant, so I'm in the same situation. I think this looks like a good change but, I can't say if it will be problematic.

@hmerk
Copy link

hmerk commented Feb 8, 2026

Used canvas layout for the demo case only, so not really having much experience with it.

@peterkappes
Copy link

Here is my comment from the community post to continue discussion here:

First of all, thank you very much for the in-depth investigation of the problem and for proposing a way to fix it. Would this also “fix” the slider widget?

Perhaps the following questions can help point us in the right direction:

  • What is the reason that, in a fixed grid, the item content is vertically centered?

  • What is the goal of the “preserve classic style” option?

In my opinion, the widgets from the standard library are not really usable at all when working with a fixed canvas. They are not consistent with the row/column or fixed grid layout.

@jsjames
Copy link
Contributor

jsjames commented Feb 26, 2026

@florian-h05 - just confirming this is no longer draft (as stated in the initial comment).

@florian-h05
Copy link
Contributor Author

Let's undraft and merge this, we are far away from 5.2.0 so we have enough time to test this and revert in case it was a bad idea.

@florian-h05 florian-h05 marked this pull request as ready for review February 26, 2026 22:34
@florian-h05 florian-h05 requested a review from ghys as a code owner February 26, 2026 22:34
@florian-h05 florian-h05 added the enhancement New feature or request label Feb 26, 2026
@florian-h05 florian-h05 added this to the 5.2 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants