Adjust persistence REST HTTP response status code#5330
Draft
Nadahar wants to merge 1 commit intoopenhab:mainfrom
Draft
Adjust persistence REST HTTP response status code#5330Nadahar wants to merge 1 commit intoopenhab:mainfrom
Nadahar wants to merge 1 commit intoopenhab:mainfrom
Conversation
…one exists For further information, see openhab/openhab-webui#3766 Signed-off-by: Ravi Nadahar <[email protected]>
Contributor
Author
|
Can anyone think of anything else than MainUI that use this endpoint? |
Contributor
|
I don’t know. Maybe Habapp, @spacemanspiff2007 ? I am fine with the change. |
Contributor
Author
|
Doubt seem to have arisen regarding if this is desired or not. I'm converting this to draft until a decision has been made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the evolution of openhab/openhab-webui#3766, it has been determined that the
getPersistenceServiceConfigurationAPI endpoint should return 204 instead of 404 if no matching configuration exists. The reason is that there is no expectation that one should exist.For a more detailed explanation, see this discussion in the PR, which is summed up here: openhab/openhab-webui#3766 (comment)
I'm holding back updating the "alerts" in distro for #5236 in case this is accepted as well, so that these changes can all be listed together.