fix: use correct SVG data format for autogenerated zones by Agrendalath · Pull Request #518 · openedx/xblock-drag-and-drop-v2

Agrendalath · 2026-03-23T19:45:20Z

This fixes content type recognition in Chrome 146, caused by https://developer.chrome.com/release-notes/146#data_url_mime_type_parameter_preservation.

Description

This moves SVG metadata from MIME type parameters to the SVG node's data attributes. This way, the content is correctly recognized by Chrome 146.

Testing instructions

Use Chrome 146.
Create a DnDv2 without this branch.
Go to "Edit" -> "Continue".
Select "Generate image automatically" and press the "Generate image and zones" button.
Check that the zone images (next to "Zone definitions") are not displayed correctly.
Fill in a "Description" for each zone, and go to "Continue" -> "Save".
The XBlock should no longer be rendered correctly in both Studio and LMS.
Check out this branch.
See that the XBlock is now rendered correctly, and the zone generation (in the Studio editor) works as well.

Deadline

"None", but it would be nice to fix it sooner rather than later, since it affects all instances.

Other information

Related discussion: https://discuss.openedx.org/t/chrome-version-146-0-x-breaks-on-svg-automatic-generation-for-drag-and-drop-xblock/18618

This fixes content type recognition in Chrome 146.

openedx-webhooks · 2026-03-23T19:45:24Z

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @Agrendalath.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks · 2026-03-23T19:45:25Z

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @Agrendalath.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Agrendalath · 2026-03-23T19:48:18Z

drag_and_drop_v2/public/js/drag_and_drop_edit.js

+                    if (Object.keys(params).length > 0) {
+                        return params;
+                    }
+                    // Legacy format: params encoded in the MIME type section of the data URI.


I kept it for the editor's compatibility with the previous format. I could have used the converted URI from the backend here, but I wanted to avoid potential side effects, since this editor is quite complex.

Agrendalath · 2026-03-23T19:49:26Z

drag_and_drop_v2/public/js/drag_and_drop_edit.js

                            var autozone_data = _fn.build.form.zone.calculateAutozoneData(params);
                            var svg = _fn.tpl.autozoneSvg(autozone_data).trim();
-                            var data_uri_params = _fn.build.encodeDataUriParams({
-                                producer: 'dndv2',


I hardcoded the producer in the autozone-tpl, since it never changes.

Agrendalath · 2026-03-23T19:50:18Z

drag_and_drop_v2/drag_and_drop_v2.py

            'fields': self.fields,
            'showanswer_set': self._field_data.has(self, 'showanswer'),  # If false, we're using an inherited value.
            'self': self,
-            'data': six.moves.urllib.parse.quote(json.dumps(self.data)),


This is not directly related, but I wanted to ensure that we do not use this data anywhere in the editor.

Agrendalath · 2026-03-23T19:50:58Z

drag_and_drop_v2/drag_and_drop_v2.py

+        if not match:
+            return data_uri


This should never happen, but I have added it as a failsafe.

kdmccormick · 2026-03-24T19:47:41Z

Thanks!

fix: use correct SVG data format for autogenerated zones

498382f

This fixes content type recognition in Chrome 146.

Agrendalath self-assigned this Mar 23, 2026

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 23, 2026

openedx-webhooks added this to Contributions Mar 23, 2026

github-project-automation bot moved this to Needs Triage in Contributions Mar 23, 2026

Agrendalath commented Mar 23, 2026

View reviewed changes

Agrendalath moved this from Needs Triage to Ready for Review in Contributions Mar 23, 2026

Agrendalath requested a review from a team March 24, 2026 16:36

kdmccormick approved these changes Mar 24, 2026

View reviewed changes

kdmccormick merged commit 58f3879 into openedx:master Mar 24, 2026
6 checks passed

github-project-automation bot moved this from Ready for Review to Done in Contributions Mar 24, 2026

Agrendalath deleted the agrendalath/fix-autogenerated-zones branch March 25, 2026 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use correct SVG data format for autogenerated zones#518

fix: use correct SVG data format for autogenerated zones#518
kdmccormick merged 1 commit intoopenedx:masterfrom
open-craft:agrendalath/fix-autogenerated-zones

Agrendalath commented Mar 23, 2026

Uh oh!

openedx-webhooks commented Mar 23, 2026

Uh oh!

openedx-webhooks commented Mar 23, 2026

Uh oh!

Agrendalath Mar 23, 2026

Uh oh!

Agrendalath Mar 23, 2026

Uh oh!

Agrendalath Mar 23, 2026

Uh oh!

Agrendalath Mar 23, 2026

Uh oh!

kdmccormick commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Agrendalath commented Mar 23, 2026

Description

Testing instructions

Deadline

Other information

Uh oh!

openedx-webhooks commented Mar 23, 2026

Uh oh!

openedx-webhooks commented Mar 23, 2026

Uh oh!

Agrendalath Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Agrendalath Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Agrendalath Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Agrendalath Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

kdmccormick commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants