Skip to content

feat: longer task retry delays, no jitter #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iloveagent57 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: longer task retry delays, no jitter #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions enterprise_catalog/apps/api/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,14 @@ class LoggedTaskWithRetry(LoggedTask): # pylint: disable=abstract-method
IntegrityError,
OperationalError,
)
retry_kwargs = {'max_retries': 5}
# Use exponential backoff for retrying tasks
retry_backoff = True
# Add randomness to backoff delays to prevent all tasks in queue from executing simultaneously
retry_jitter = True
# https://docs.celeryq.dev/en/stable/userguide/tasks.html#Task.retry_backoff
# The retry backoff calculation is computed as (retry_backoff * 2**(retry count))
# The retry delay with the configuration below will result in retry delays of
# [20, 40, 60, 60, 60] seconds.
retry_backoff = 20
retry_backoff_max = 60
max_retries = 5
retry_jitter = False


@shared_task(base=LoggedTaskWithRetry, bind=True, default_retry_delay=UNREADY_TASK_RETRY_COUNTDOWN_SECONDS)
Expand Down