fix: Multi Select course/course run issue#4714
fix: Multi Select course/course run issue#4714skumargupta83 wants to merge 1 commit intoopenedx:masterfrom
Conversation
321ae47 to
1fc5760
Compare
1fc5760 to
a57d163
Compare
ankit-sonata
left a comment
There was a problem hiding this comment.
Tests are overly “implementation-detail heavy” and may be brittle
DALAdminMixinTests asserts exact tuples and exact ordering/length of media assets. This will be fragile if upstream changes asset names/paths or admin media composition.
Prefer testing the behavioral requirement: “Select2 appears before autocomplete.js” and “required assets are included”, rather than full equality of tuples.
test_widgets.py additions are too mock-y and don’t strongly validate the real bug
Many tests patch DAL base methods and then assert shallow properties (e.g., “doesn’t crash”, “result is not None”).
Suggest focusing on 2–3 high-value tests:
optgroups preserves order of selected values (core bug),
handles missing/empty items safely,
ensures data-role="autocomplete" ends up in rendered widget attrs (if that’s truly required).
|
Hi @ankit-sonata, |
|
an alternative proposed approach to this issue: #4718 |
ankit-sonata
left a comment
There was a problem hiding this comment.
- Change DALAdminMixin to not inherit from ModelAdmin (make it a plain class/object)
- Remove duplicated Media CSS/JS from CourseAdmin and ProgramAdmin inner Media classes, OR remove the mixin and keep everything inline — pick one pattern
- Remove the no-op media property from SortedModelSelect2Multiple
|
As discussed with @iloveagent57, I am closing PR #4714 and continuing with PR #4718. Thanks |
https://2u-internal.atlassian.net/browse/CATALOG-44
Unable to Enter Course and Org Data- Discovery
Description
A recent update in the Discovery is preventing users from entering information in the Courses and Authoring Organization fields. This is impacting high-priority program operations, specifically for Google Cloud initiatives that require quick turnaround. The affected user reported being unable to input necessary data in these fields and requests an urgent resolution to restore data entry capabilities
Acceptance Criteria :
The Courses and Authoring Organization fields must allow data entry without errors for all users.
No existing programs or scheduled launches should be disrupted during the patch or rollback.