Smartnoise-sql - Opendp 0.14.1: Fix float domains that implicitly allows NaN#626
Open
LancelotMarti wants to merge 3 commits intoopendp:mainfrom
Open
Smartnoise-sql - Opendp 0.14.1: Fix float domains that implicitly allows NaN#626LancelotMarti wants to merge 3 commits intoopendp:mainfrom
LancelotMarti wants to merge 3 commits intoopendp:mainfrom
Conversation
Author
|
Related to #625 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelines using floating-point domains may fail during construction in v0.14 because
atom_domain(T=float)implicitly allowsNaNvalues. Transformations such asthen_clampandthen_sumreject domains that may containNaN, leading to the error:OpenDPException: FailedFunction("Domain contains nan")This change ensures pipelines behave as expected by explicitly disabling
NaNin the input domain.