Add space-ratio option - #649
Merged
Merged
Conversation
LonelyMidoriya
requested review from
MaximPlusov,
bundolee,
hnc-jglee and
hyunhee-jo
as code owners
July 23, 2026 14:35
Contributor
WalkthroughAdds an optional TextLine space ratio across Java configuration, CLI parsing, preprocessing, parallel processing, JSON option metadata, and Python conversion bindings. It also updates image-resolution documentation, dependency versioning, and CLI option coverage. ChangesTextLine space ratio
Sequence Diagram(s)sequenceDiagram
participant PythonConvert
participant CLIOptions
participant Config
participant DocumentProcessor
participant StaticContainers
participant TextLineProcessor
PythonConvert->>CLIOptions: Pass --space-ratio value
CLIOptions->>Config: setSpaceRatio(double)
DocumentProcessor->>Config: getSpaceRatio()
DocumentProcessor->>StaticContainers: Set and propagate ratio
TextLineProcessor->>StaticContainers: Read ratio
TextLineProcessor->>TextLineProcessor: Compute spacing threshold
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java`:
- Around line 390-398: Update the NumberFormatException handler in CLIOptions to
pass the caught exception e as the cause when constructing
IllegalArgumentException, preserving the original parsing stack trace while
retaining the existing error message.
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/Config.java`:
- Around line 394-396: Update Config.setTextLineSpaceRatio to reject null?
Preserve documented nullable behavior, but validate non-null values as finite
and within the documented ratio domain before storing them. In CLIOptions, route
parsed text-line-space ratios through this setter and convert validation
failures into a clear CLI parse error; apply the changes in Config.java:394-396
and CLIOptions.java:390-398.
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.java`:
- Around line 656-659: Update the per-page worker state propagation in
processDocument so propagateState.run() also copies the configured
textLineSpaceRatio from StaticContainers, alongside the other StaticContainers
and StaticLayoutContainers ThreadLocal values. Ensure workers use the ratio
captured from config rather than their own default or stale state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ec5c231c-9d41-4b7b-b413-6f3b45e87118
⛔ Files ignored due to path filters (2)
node/opendataloader-pdf/src/cli-options.generated.tsis excluded by!**/*.generated.*node/opendataloader-pdf/src/convert-options.generated.tsis excluded by!**/*.generated.*
📒 Files selected for processing (6)
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/Config.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.javaoptions.jsonpython/opendataloader-pdf/src/opendataloader_pdf/cli_options_generated.pypython/opendataloader-pdf/src/opendataloader_pdf/convert_generated.py
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java`:
- Around line 397-398: Update the IllegalArgumentException message in the CLI
option parsing logic to reference the registered --space-ratio flag instead of
--text-line-space-ratio, while preserving the existing validation and exception
cause.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0596e800-3a38-4ee1-91f3-37ec36a15925
⛔ Files ignored due to path filters (2)
node/opendataloader-pdf/src/cli-options.generated.tsis excluded by!**/*.generated.*node/opendataloader-pdf/src/convert-options.generated.tsis excluded by!**/*.generated.*
📒 Files selected for processing (7)
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/Config.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/TextLineProcessor.javaoptions.jsonpython/opendataloader-pdf/src/opendataloader_pdf/cli_options_generated.pypython/opendataloader-pdf/src/opendataloader_pdf/convert_generated.py
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java (2)
284-284: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winAlign the exported default with the documented default.
This definition exports
default: null, whileSPACE_RATIO_DESCdocuments0.17as the default. Generated option metadata and bindings can therefore advertise an unset value. Either export"0.17"or explicitly document thatnullmeans “use the processor default of 0.17.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java` at line 284, The SPACE_RATIO_LONG_OPTION definition currently exports a null default while SPACE_RATIO_DESC documents 0.17. Update this OptionDefinition to export "0.17" as the default, keeping the generated metadata aligned with the documented processor behavior.
392-400: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winReject non-finite and negative ratios.
Double.parseDoubleacceptsNaN, infinities, and negative values. These produce invalid spacing thresholds and can silently disable or over-insert spaces. Validate that the parsed value is finite and non-negative before storing it, and add coverage for these inputs.Proposed validation
Double spaceRatio = Double.parseDouble(commandLine.getOptionValue(SPACE_RATIO_LONG_OPTION)); +if (!Double.isFinite(spaceRatio) || spaceRatio < 0.0) { + throw new IllegalArgumentException( + "Option --space-ratio requires a finite, non-negative value."); +} config.setSpaceRatio(spaceRatio);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java` around lines 392 - 400, Update the space-ratio parsing in CLIOptions to reject non-finite or negative values after Double.parseDouble and before config.setSpaceRatio. Preserve the existing invalid-number exception behavior, and add coverage for NaN, positive/negative infinity, and negative ratios.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java`:
- Line 284: The SPACE_RATIO_LONG_OPTION definition currently exports a null
default while SPACE_RATIO_DESC documents 0.17. Update this OptionDefinition to
export "0.17" as the default, keeping the generated metadata aligned with the
documented processor behavior.
- Around line 392-400: Update the space-ratio parsing in CLIOptions to reject
non-finite or negative values after Double.parseDouble and before
config.setSpaceRatio. Preserve the existing invalid-number exception behavior,
and add coverage for NaN, positive/negative infinity, and negative ratios.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c3bf4049-b981-4359-994b-f60cfb2f702a
📒 Files selected for processing (1)
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java
LonelyMidoriya
force-pushed
the
text-line-space-ratio
branch
from
July 29, 2026 08:51
87ad805 to
5063241
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.java`:
- Around line 399-411: Add focused tests for the SPACE_RATIO_LONG_OPTION parsing
in CLIOptions, covering positive decimal values and rejection of zero, negative,
NaN, infinity, and malformed input. Include an end-to-end test that configures a
ratio and verifies it changes text-line spacing, using the existing CLI parsing
and PDF/text layout test utilities.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 50917309-4a26-4a75-b95a-5e7fd591d101
⛔ Files ignored due to path filters (2)
node/opendataloader-pdf/src/cli-options.generated.tsis excluded by!**/*.generated.*node/opendataloader-pdf/src/convert-options.generated.tsis excluded by!**/*.generated.*
📒 Files selected for processing (9)
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/Config.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/api/cli/CLIOptions.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.javajava/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/TextLineProcessor.javajava/pom.xmloptions.jsonpython/opendataloader-pdf/src/opendataloader_pdf/cli_options_generated.pypython/opendataloader-pdf/src/opendataloader_pdf/convert_generated.pyverification/ci-verify.py
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
MaximPlusov
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Summary by CodeRabbit
space_ratio) to control automatic whitespace insertion during PDF text parsing, using a threshold of space-ratio × font size (decimals supported). Default behavior is 0.17.--space-ratiowith validation (must be finite and > 0).--image-resolutionfrom 288.0 to 144.0.