Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1256 +/- ##
==========================================
+ Coverage 84.31% 84.41% +0.09%
==========================================
Files 66 66
Lines 5497 5498 +1
Branches 1265 1265
==========================================
+ Hits 4635 4641 +6
+ Misses 556 551 -5
Partials 306 306 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@cdiener - can you please review? |
Member
|
Not an expert in type annotations. Looks a bit hacky to me. Could it not just by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed type hints in dictlist to be TypeVar(Object), because otherwise my linter would complain about expecting a Reaction and getting Object from model.reactions.get_by_id(). Similarly for other interactions with dictlists.
Doesn't change functionality.