Standardize country codes to ISO 3166-1 alpha-3 format#158
Open
Koolvansh07 wants to merge 1 commit intoopenclimatefix:mainfrom
Open
Standardize country codes to ISO 3166-1 alpha-3 format#158Koolvansh07 wants to merge 1 commit intoopenclimatefix:mainfrom
Koolvansh07 wants to merge 1 commit intoopenclimatefix:mainfrom
Conversation
Fixes openclimatefix#157 Changes: - gb -> gbr_gb (Great Britain) - nl -> nld (Netherlands) - de -> deu (Germany) - be -> bel (Belgium) - ind_rajasthan -> ind_rj (India - Rajasthan) Updated files: - solar_consumer/fetch_data.py - solar_consumer/app.py - solar_consumer/save/save_data_platform.py - solar_consumer/save/save_site_database.py - tests/unit/test_fetch_data.py - tests/unit/test_save_forecast.py - tests/integration/test_save_nl_to_data_platform.py - README.md - .example.env All country codes now follow ISO 3166-1 alpha-3 standard.
Author
|
Saw this issue was open and had some time, so figured I'd tackle it. Changed the country codes to the ISO standard as requested. Let me know if I missed anything! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR standardizes all country codes in the solar-consumer project to follow the ISO 3166-1 alpha-3 standard as requested in issue #157.
Changes made:
gbr_gb(Great Britain - excluding Northern Ireland)nld(Netherlands)deu(Germany)be→bel(Belgium)ind_rj(India - Rajasthan)Files updated:
All country codes now follow the ISO 3166-1 alpha-3 standard, maintaining functionality while improving standardization.
Fixes #157
How Has This Been Tested?
Testing performed:
Test results:
Note: Full unit and integration tests require dependencies to be installed. The changes maintain the same logic flow, only updating the country code strings.
Data processing sanity check:
Checklist: