Skip to content

Get the NL generation data to save to dataplatform#155

Merged
katyalmohit merged 9 commits intomainfrom
nednl-dp
Feb 5, 2026
Merged

Get the NL generation data to save to dataplatform#155
katyalmohit merged 9 commits intomainfrom
nednl-dp

Conversation

@katyalmohit
Copy link
Contributor

@katyalmohit katyalmohit commented Feb 4, 2026

Pull Request

Description

Implemented the feature to save NL generation data to data platform

Fixes #146

How Has This Been Tested?

  • Tested locally
  • Added unit tests and integration tests

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@PavanRaghavendraKulkarni
Copy link
Contributor

  1. This PR has merge Conflicts please resolve them
  2. Integration Test cases are missing

Copy link
Contributor

@PavanRaghavendraKulkarni PavanRaghavendraKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Resolve Merge conflicts and Add a integration test cases

@katyalmohit
Copy link
Contributor Author

I have added the integration test for NL data and moved the redundant part in the tests/integration/conftest.py file.

@katyalmohit katyalmohit merged commit fef134d into main Feb 5, 2026
8 checks passed
@katyalmohit katyalmohit deleted the nednl-dp branch February 5, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save NL to data-platform

2 participants