Skip to content

chore: remove old data config#78

Open
AnujNayak108 wants to merge 1 commit intoopenclimatefix:mainfrom
AnujNayak108:old-data-config-removal
Open

chore: remove old data config#78
AnujNayak108 wants to merge 1 commit intoopenclimatefix:mainfrom
AnujNayak108:old-data-config-removal

Conversation

@AnujNayak108
Copy link

Pull Request

Description

This PR removes the unused live_delay_minutes field from site_forecast_app/models/pvnet/utils.py.
After searching through:

This repo → only found in utils.py, where it was immediately removed from satellite_config.

Config generation repo → not present.

HuggingFace configs → not present in the satellite section or elsewhere.

Therefore, this field is no longer needed and can safely be removed.

Fixes #74

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova
Copy link
Contributor

Hi @AnujNayak108, thanks for putting this up but I can see that the CI runs have failed, and since there hasn't been any work done on this PR in a while I am going to close this. Let me know if you want to pick this back up!

@AUdaltsova AUdaltsova closed this Nov 18, 2025
@AnujNayak108
Copy link
Author

Hi @AUdaltsova I’d like to continue working on this PR.
Could you please guide me on what exactly is failing in the CI checks?

What I noticed the tests were failing because some of the data_config.yaml files could not be downloaded from Hugging Face during CI, and I wasn’t sure whether this was a network issue, a missing mock, or something expected in this repo. If you could point me to the relevant failing step or confirm the expected behaviour, I’d be happy to fix it properly and reopen the PR.

@AUdaltsova AUdaltsova reopened this Dec 2, 2025
@AUdaltsova
Copy link
Contributor

Hi @AnujNayak108, thanks for getting back to me & for being ready to work on the issue! I've reopened the PR now. Very odd that the tests are not passing, I've merged a couple of PRs recently and had no CI issues. Not sure what's wrong here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old data config value check

2 participants