Skip to content

Conversation

@devsjc
Copy link
Contributor

@devsjc devsjc commented Nov 12, 2025

  • Have you followed the Open Climate Fix Contribution Guidelines?
  • Have you referenced the Issue this PR addresses?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added a summary of the changes?
  • Have you written new tests for your changes?.
  • Have you successfully run make lint with your changes locally?
  • Have you successfully run make gen with your changes locally?
  • Have you successfully run make test with your changes locally?

Adds a test suite for the CreateObservations RPC

@github-actions
Copy link

Benchmark Results

Benchmark results
?   	github.com/openclimatefix/data-platform/cmd	[no test files]
?   	github.com/openclimatefix/data-platform/internal/gen/ocf/dp	[no test files]
?   	github.com/openclimatefix/data-platform/internal/interceptors	[no test files]
PASS
ok  	github.com/openclimatefix/data-platform/internal/server/dummy	0.005s
{"level":"debug","time":"2025-11-12T14:31:37Z","message":"Running migrations"}
goos: linux
goarch: amd64
pkg: github.com/openclimatefix/data-platform/internal/server/postgres
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkPostgresClient/6144000/GetForecastAsTimeseries-4         	     150	   7693966 ns/op
BenchmarkPostgresClient/6144000/GetForecastAtTimestamp-4          	      37	  29646027 ns/op
BenchmarkPostgresClient/6144000/GetObservationsAsTimeseries-4     	     891	   1261883 ns/op
BenchmarkPostgresClient/6144000/CreateForecast-4                  	     261	   4203499 ns/op
PASS
ok  	github.com/openclimatefix/data-platform/internal/server/postgres	186.107s
?   	github.com/openclimatefix/data-platform/internal/server/postgres/gen	[no test files]
Benchmark vs base branch
goos: linux
goarch: amd64
pkg: github.com/openclimatefix/data-platform/internal/server/postgres
cpu: AMD EPYC 7763 64-Core Processor                
                                                     │ bench-main.txt │ bench-devsjc-create-observations-test.txt │
                                                     │     sec/op     │      sec/op        vs base                │
PostgresClient/6144000/GetForecastAsTimeseries-4         4.826m ± ∞ ¹        7.694m ± ∞ ¹       ~ (p=1.000 n=1) ²
PostgresClient/6144000/GetForecastAtTimestamp-4         105.00m ± ∞ ¹        29.65m ± ∞ ¹       ~ (p=1.000 n=1) ²
PostgresClient/6144000/GetObservationsAsTimeseries-4     1.307m ± ∞ ¹        1.262m ± ∞ ¹       ~ (p=1.000 n=1) ²
PostgresClient/6144000/CreateForecast-4                  2.612m ± ∞ ¹        4.203m ± ∞ ¹       ~ (p=1.000 n=1) ²
geomean                                                  6.449m              5.898m        -8.55%
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

@devsjc devsjc merged commit 5ae5e6a into main Nov 12, 2025
2 checks passed
@devsjc devsjc deleted the devsjc/create-observations-test branch November 12, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants