Skip to content

Conversation

@devsjc
Copy link
Contributor

@devsjc devsjc commented Jan 6, 2026

Contribution Checklist

  • Have you followed the Open Climate Fix Contribution Guidelines?
  • Have you referenced the Issue this PR addresses, where applicable?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added a summary of the changes?
  • Have you written new tests for your changes, where applicable?
  • Have you successfully run make lint with your changes locally?
  • Have you successfully run make test with your changes locally?

Warning

PRs may be closed if all the above boxes are not checked.

Changes in this Pull Request

Corrects the GetLatestForecasts query to speed it up (10s -> 0.1s). Previously it was fetching all forecasts (woops) then ordering, now using DISTINCT it stops the scan immediately upon finding a value. Stupid mistake, luckily, easy to debug and sort!

@devsjc devsjc force-pushed the devsjc/getlatestforecasts-speedup branch from 9b75cd2 to 94b9593 Compare January 6, 2026 11:41
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Benchmark Results

Benchmark results
?   	github.com/openclimatefix/data-platform/cmd	[no test files]
?   	github.com/openclimatefix/data-platform/internal/gen/ocf/dp	[no test files]
?   	github.com/openclimatefix/data-platform/internal/interceptors	[no test files]
PASS
ok  	github.com/openclimatefix/data-platform/internal/server/dummy	0.005s
{"level":"debug","time":"2026-01-06T11:42:54Z","message":"Running migrations"}
goos: linux
goarch: amd64
pkg: github.com/openclimatefix/data-platform/internal/server/postgres
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkPostgresClient/6144000/GetForecastAsTimeseries-4         	     166	   6864265 ns/op
BenchmarkPostgresClient/6144000/GetForecastAtTimestamp-4          	      45	  23551824 ns/op
BenchmarkPostgresClient/6144000/GetObservationsAsTimeseries-4     	     936	   1213542 ns/op
BenchmarkPostgresClient/6144000/CreateForecast-4                  	     273	   4106420 ns/op
PASS
ok  	github.com/openclimatefix/data-platform/internal/server/postgres	184.248s
?   	github.com/openclimatefix/data-platform/internal/server/postgres/gen	[no test files]
Benchmark vs base branch
goos: linux
goarch: amd64
pkg: github.com/openclimatefix/data-platform/internal/server/postgres
cpu: AMD EPYC 7763 64-Core Processor                
                                                     │ bench-main.txt │ bench-devsjc-getlatestforecasts-speedup.txt │
                                                     │     sec/op     │       sec/op        vs base                 │
PostgresClient/6144000/GetForecastAsTimeseries-4         4.826m ± ∞ ¹         6.864m ± ∞ ¹        ~ (p=1.000 n=1) ²
PostgresClient/6144000/GetForecastAtTimestamp-4         105.00m ± ∞ ¹         23.55m ± ∞ ¹        ~ (p=1.000 n=1) ²
PostgresClient/6144000/GetObservationsAsTimeseries-4     1.307m ± ∞ ¹         1.214m ± ∞ ¹        ~ (p=1.000 n=1) ²
PostgresClient/6144000/CreateForecast-4                  2.612m ± ∞ ¹         4.106m ± ∞ ¹        ~ (p=1.000 n=1) ²
geomean                                                  6.449m               5.328m        -17.39%
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

@devsjc devsjc merged commit f3ffd1f into main Jan 6, 2026
3 checks passed
@devsjc devsjc deleted the devsjc/getlatestforecasts-speedup branch January 6, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants