Use autovariables to reduce redundancy in rule definitions#246
Draft
jamezpolley wants to merge 2 commits intomainfrom
Draft
Use autovariables to reduce redundancy in rule definitions#246jamezpolley wants to merge 2 commits intomainfrom
jamezpolley wants to merge 2 commits intomainfrom
Conversation
2b7bdab to
6391dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends-on: #245
The intention here is to reduce redundancy in rule definitions, so that it's easier to ensure that any change that applies to all the related targets does apply to all of them.
The way it achieves this is via the $@ auto-variable so that we can have one rule with multiple targets, and run the command only on the target that was invoked.
$(patsubst tf-%,%,$@)However, I'm not sure if the outcome is good. On the plus side - it does remove redundancy. On the minus side - it loses readability, and I'm not sure that the reduction in redundancy justifies the loss of readability.
Feedback requested!