fix authenticated_server_python WWW-Authenticate formatting#199
Draft
chi5477 wants to merge 1 commit intoopenai:mainfrom
Draft
fix authenticated_server_python WWW-Authenticate formatting#199chi5477 wants to merge 1 commit intoopenai:mainfrom
chi5477 wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a formatting bug in the OAuth challenge string returned by the Python authenticated MCP example.
What was wrong
In
authenticated_server_python/main.py, the generatedWWW-Authenticatechallenge concatenatederroranderror_descriptionwithout a comma separator.Before:
error="..."error_description="..."This produces a malformed challenge value and can cause OAuth clients to parse the auth hint inconsistently.
Root cause
A missing delimiter in
_build_www_authenticate_value(...)when composing challenge parameters.Fix
Add the missing comma+space between
erroranderror_descriptionin the formatted string.After:
error="...", error_description="..."Validation
see_past_ordersvia/mcp.mcp/www_authenticatenow returns a correctly formatted challenge:Bearer error="invalid_request", error_description="No access token was provided", resource_metadata="..."Scope