Lazily initialize diskcache to avoid creating cache directory on import#127
Open
andrewjcg wants to merge 1 commit intoopenai:mainfrom
Open
Lazily initialize diskcache to avoid creating cache directory on import#127andrewjcg wants to merge 1 commit intoopenai:mainfrom
andrewjcg wants to merge 1 commit intoopenai:mainfrom
Conversation
The module-level `dc.Cache("cache")` call in `data.py` creates a `cache/`
directory in the current working directory at import time, even when the
cache is never used (e.g. during test discovery). This is problematic for
environments where mlebench is imported from a read-only or shared directory.
Replace the eager cache initialization with a lazy `_get_cache()` helper that
only creates the diskcache when `get_checksum()` is actually called.
Author
|
This fixes some issues where this cache was being creating (in CWD) on module import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module-level
dc.Cache("cache")call indata.pycreates acache/directory in the current working directory at import time, even when the cache is never used (e.g. during test discovery). This is problematic for environments where mlebench is imported from a read-only or shared directory.Replace the eager cache initialization with a lazy
_get_cache()helper that only creates the diskcache whenget_checksum()is actually called.