Extract codex-extensions from codex-core#15028
Extract codex-extensions from codex-core#15028aibrahim-oai wants to merge 5 commits intocodex/split-core-config-loaderfrom
Conversation
Co-authored-by: Codex <[email protected]>
|
@codex review this |
Co-authored-by: Codex <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Re-add conversion from plugin detail to capability summary
This .into() now has no matching From<PluginDetailSummary> for PluginCapabilitySummary implementation after extraction. cargo check -p codex-core fails with E0277 here, blocking compilation of plugin discovery.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let capability_summaries = plugins | ||
| .iter() | ||
| .filter_map(PluginCapabilitySummary::from_plugin) | ||
| .filter_map(plugin_capability_summary_from_loaded_plugin) |
There was a problem hiding this comment.
PluginLoadOutcome::from_plugins still calls plugin_capability_summary_from_loaded_plugin, but that symbol is no longer defined/imported after the extraction. cargo check -p codex-core now fails with E0425 at this line, so the crate cannot build.
Useful? React with 👍 / 👎.
| let target = target_root.join(plugin_version); | ||
| let staging = target_root.join(format!(".{plugin_version}.tmp")); | ||
| remove_existing_target(staging.as_path())?; | ||
| remove_existing_target(target.as_path())?; | ||
|
|
||
| copy_dir_recursive(source, staging.as_path())?; | ||
| fs::rename(staging.as_path(), target.as_path()) |
There was a problem hiding this comment.
The new install path only removes/replaces <target_root>/<plugin_version> and leaves other version directories in place. When an update installs a new version, multiple versions remain; active_plugin_version then returns None (it requires exactly one), so plugins can become effectively inactive after upgrade.
Useful? React with 👍 / 👎.
Co-authored-by: Codex <[email protected]>
Co-authored-by: Codex <[email protected]>
Co-authored-by: Codex <[email protected]>
1 participant
Summary
Testing