Extract model metadata into codex-models#15026
Extract model metadata into codex-models#15026aibrahim-oai wants to merge 4 commits intocodex/split-core-config-loaderfrom
Conversation
Co-authored-by: Codex <[email protected]>
Co-authored-by: Codex <[email protected]>
|
@codex review this |
Co-authored-by: Codex <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e02add131a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/client.rs
Outdated
| let api_provider = self.state.provider.to_api_provider(matches!( | ||
| auth.as_ref().map(CodexAuth::auth_mode), | ||
| Some(crate::auth::AuthMode::Chatgpt) | ||
| ))?; |
There was a problem hiding this comment.
? from to_api_provider call sites
ModelProviderInfo::to_api_provider was refactored to return Provider directly, but this call still applies ?. That no longer compiles because Provider does not implement Try. The same regression also appears in core/src/models_manager/manager.rs and core/src/realtime_conversation.rs, causing cargo check -p codex-core to fail.
Useful? React with 👍 / 👎.
Co-authored-by: Codex <[email protected]>
1 participant
Summary
codex-modelscratecodex-coreas a thin facade over the moved model metadata modulescodex-modelsdirectly for the extracted types and helpersTesting