Forward session and turn headers to MCP HTTP requests#15011
Open
nicholasclark-openai wants to merge 6 commits intomainfrom
Open
Forward session and turn headers to MCP HTTP requests#15011nicholasclark-openai wants to merge 6 commits intomainfrom
nicholasclark-openai wants to merge 6 commits intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Co-authored-by: Codex <noreply@openai.com>
chenglong-openai
approved these changes
Mar 18, 2026
Co-authored-by: Codex <noreply@openai.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
nicholasclark-openai
changed the title
nicholasclark-openai
changed the title
pakrym-oai
reviewed
Mar 18, 2026
|
|
||
| impl ManagedClient { | ||
| fn listed_tools(&self) -> Vec<ToolInfo> { | ||
| fn listed_tools(&self, _request_headers: Option<reqwest::header::HeaderMap>) -> Vec<ToolInfo> { |
pakrym-oai
reviewed
Mar 18, 2026
| tool_plugin_provenance: Arc<ToolPluginProvenance>, | ||
| } | ||
|
|
||
| struct StartupRequestHeadersGuard { |
pakrym-oai
reviewed
Mar 18, 2026
| #[derive(Clone)] | ||
| struct StreamableHttpResponseClient { | ||
| inner: reqwest::Client, | ||
| request_headers_state: Arc<StdMutex<Option<HeaderMap>>>, |
Collaborator
There was a problem hiding this comment.
Are we reusing the same client while mutating headers from various calls? Is there a data race?
Collaborator
There was a problem hiding this comment.
I.e. if two threads call client in parallel, who's headers win?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing