Skip to content

Conversation

@franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Sep 30, 2025

TODO

  • error handling
  • can we use ADIOS2 as a block storage backend?
  • do not always try creating the bucket, only if we need to
  • JSON merging (MPI)
  • async IO
  • (probably for later PR) non-matching load operations
  • merge script: read file names from stdin, not from command line args
  • ensure that restarting will not overwrite old blocks
  • JSON backend: provide backend-specific implementation for Span API: we profit from using unique_ptr types in async AWS
  • do we need some handling for runningIndex in the JSON files?

else
{
// sic! initialize the deferred json config as a new
// tracing object
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Return warning upon unused keys

/* convertLowercase = */ false);
for (++begin; begin != end; ++begin)
{
auto [next, _] = json::parseOptions(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
}

template <typename Arg, typename... Args>
auto prepend_to_json(nlohmann::json j, Arg &&arg, Args &&...args)

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable args is never read.
}

template <typename Arg, typename... Args>
auto prepend_to_json(nlohmann::json j, Arg &&arg, Args &&...args)

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable args is not used.
template <typename... Args>
void warnUnusedJson(
openPMD::json::TracingJSON const &jsonConfig,
Args &&...extra_json_hierarchy)

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable extra_json_hierarchy is never read.
template <typename... Args>
void warnUnusedJson(
openPMD::json::TracingJSON const &jsonConfig,
Args &&...extra_json_hierarchy)

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable extra_json_hierarchy is not used.
chunk_assignment::mergeChunks(*parameters.chunks);
auto &j = obtainJsonContents(writable);

auto [extent, datasetmode] = getExtent(j, m_datasetMode.m_mode);

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable extent is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant