Skip to content

Update "mathematical shapeS" to "... shape" (singular) #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Raphael-Gazzotti merged 3 commits into from
Oct 31, 2025
Merged

Update "mathematical shapeS" to "... shape" (singular) #303

Raphael-Gazzotti merged 3 commits into from
Oct 31, 2025

Conversation

@UlrikeS91
Copy link
Collaborator

@UlrikeS91 UlrikeS91 commented Oct 28, 2025

@UlrikeS91 UlrikeS91 self-assigned this Oct 28, 2025
@UlrikeS91 UlrikeS91 added request any request or update for schemas v5.0 candidate labels Oct 28, 2025
@UlrikeS91 UlrikeS91 linked an issue Oct 28, 2025 that may be closed by this pull request
correct category "mathematicalShapes" to "mathematicalShape" #299
Closed
@Raphael-Gazzotti Raphael-Gazzotti merged commit 666a157 into v4 Oct 31, 2025
2 checks passed
@Raphael-Gazzotti Raphael-Gazzotti deleted the UlrikeS91-mathShape-update branch October 31, 2025 10:19
@apdavison
Copy link
Member

apdavison commented Nov 7, 2025 •
edited
Loading

I think this should have been made against branch v5, since SANDS v4 was the one that went into openMINDS v4.0, and this is targeting openMINDS v5.0.

If this is correct, we should probably revert v4 back to [8920b4e]

Raphael-Gazzotti added a commit that referenced this pull request Nov 12, 2025
@Raphael-Gazzotti
Revert "Merge pull request #303 from openMetadataInitiative/UlrikeS91…
d4942d8 
…-mathShape-update"

This reverts commit 666a157, reversing
changes made to 8920b4e.
@Raphael-Gazzotti
Copy link
Member

Raphael-Gazzotti commented Nov 12, 2025

The v4 branch has been reverted. The changes were already included in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raphael-Gazzotti Raphael-Gazzotti Raphael-Gazzotti approved these changes

@lzehl lzehl Awaiting requested review from lzehl

Assignees

@UlrikeS91 UlrikeS91

Labels

request any request or update for schemas v5.0 candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

correct category "mathematicalShapes" to "mathematicalShape"

3 participants

@UlrikeS91 @apdavison @Raphael-Gazzotti