Skip to content

docs: fix README app.kubernetes.io/instance issue - #4345

Merged
swiatekm merged 1 commit into
open-telemetry:mainfrom
blue86321:fix-readme-instance-name-issue
Jan 7, 2026
Merged

docs: fix README app.kubernetes.io/instance issue#4345
swiatekm merged 1 commit into
open-telemetry:mainfrom
blue86321:fix-readme-instance-name-issue

Conversation

@blue86321

@blue86321 blue86321 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Description:

In README ### Configure resource attributes with labels section,
claims that label app.kubernetes.io/instance will become service.instance, which is incorrect.

Label app.kubernetes.io/instance will indeed become service.name as in #3797

This logic is still valid if we go deep into the code

// pkg/constants/env.go
LabelAppName = []string{
  "app.kubernetes.io/instance",
  "app.kubernetes.io/name",
}

// internal/instrumentation/sdk.go # chooseServiceName
if name := chooseLabelOrAnnotation(pod, useLabelsForResourceAttributes, semconv.ServiceNameKey, constants.LabelAppName); name != "" {
  return name
}

#4081 misunderstood and falsely "fixed the typo". This PR is to re-fix this issue in README.md

@blue86321
blue86321 requested a review from a team as a code owner September 9, 2025 04:12
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 10, 2025
@frzifus
frzifus enabled auto-merge (squash) September 10, 2025 12:13
auto-merge was automatically disabled January 6, 2026 02:24

Head branch was pushed to by a user without write access

@blue86321
blue86321 force-pushed the fix-readme-instance-name-issue branch from 3969f3a to 5fc9bd7 Compare January 6, 2026 02:24
@blue86321
blue86321 requested a review from frzifus January 6, 2026 02:28
@blue86321

blue86321 commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

@frzifus this PR somehow get stuck by unit test. I just rebase the latest code and push again.

stucked CI check: https://github.com/open-telemetry/opentelemetry-operator/actions/runs/17571522619

@swiatekm
swiatekm merged commit af4e958 into open-telemetry:main Jan 7, 2026
53 of 54 checks passed
@blue86321
blue86321 deleted the fix-readme-instance-name-issue branch January 8, 2026 03:11
Sashidhar-rafay pushed a commit to RafaySystems/opentelemetry-operator that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants