docs: fix README app.kubernetes.io/instance issue - #4345
Merged
swiatekm merged 1 commit intoJan 7, 2026
Conversation
frzifus
approved these changes
Sep 10, 2025
frzifus
enabled auto-merge (squash)
September 10, 2025 12:13
auto-merge was automatically disabled
January 6, 2026 02:24
Head branch was pushed to by a user without write access
blue86321
force-pushed
the
fix-readme-instance-name-issue
branch
from
January 6, 2026 02:24
3969f3a to
5fc9bd7
Compare
Contributor
Author
|
@frzifus this PR somehow get stuck by unit test. I just rebase the latest code and push again. stucked CI check: https://github.com/open-telemetry/opentelemetry-operator/actions/runs/17571522619 |
swiatekm
approved these changes
Jan 7, 2026
Sashidhar-rafay
pushed a commit
to RafaySystems/opentelemetry-operator
that referenced
this pull request
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In README
### Configure resource attributes with labelssection,claims that label
app.kubernetes.io/instancewill becomeservice.instance, which is incorrect.Label
app.kubernetes.io/instancewill indeed becomeservice.nameas in #3797This logic is still valid if we go deep into the code
#4081 misunderstood and falsely "fixed the typo". This PR is to re-fix this issue in
README.md