fix(sdk-node)!: fail-fast on MeterProvider creation from config file - #6954
Draft
trentm wants to merge 9 commits into
Draft
fix(sdk-node)!: fail-fast on MeterProvider creation from config file#6954trentm wants to merge 9 commits into
trentm wants to merge 9 commits into
Conversation
This refactors the MeterProvider creation from declarative config in the `startNodeSDK()` code path: - fail-fast (and fallback to a no-op SDK) if the config has unknown values or values that aren't yet supported by the SDK - fixes a number of missed cases - adds a number of TODO for meter_provider config cases to follow-up on (Some of these are to keep this PR smaller, some are because sdk-metrics doesn't yet support everything the declarative config schema supports configuring.) Refs: open-telemetry#6785 Refs: open-telemetry#6107 (comment)
Pull request dashboard statusWaiting on the author · refreshed 2026-07-28 22:09 UTC Move out of draft to request review. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6954 +/- ##
==========================================
- Coverage 95.07% 94.39% -0.69%
==========================================
Files 409 409
Lines 14256 14501 +245
Branches 3267 3363 +96
==========================================
+ Hits 13554 13688 +134
- Misses 702 813 +111
🚀 New features to boost your workflow:
|
Also limit reading of TLS files to *absolute paths* as required by the declarative config. Note: that doesn't work properly for the 'build-config-from-env-vars' code path. Update to have real TLS files with the usual maint:... npm script. Real TLS files are required by createSslCredentials(), which was being masked before by the just-warn semantics.
…h handles negative, and fails-fast
trentm
commented
Jul 28, 2026
Contributor
Author
There was a problem hiding this comment.
The files and regenerate.sh script in this dir are the exact same setup we use for testable TLS files in the otlp-exporter-base and otlp-grpc-exporter-base packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the MeterProvider creation from declarative config
in the
startNodeSDK()code path:values or values that aren't yet supported by the SDK
(Some of these are to keep this PR smaller, some are because
sdk-metrics doesn't yet support everything the declarative config
schema supports configuring.)
Refs: #6785
Refs: #6107 (comment)