fix(pino): avoid mutating user options when reused#3360
Open
MUSKANNISHAD wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(pino): avoid mutating user options when reused#3360MUSKANNISHAD wants to merge 2 commits intoopen-telemetry:mainfrom
MUSKANNISHAD wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
MUSKANNISHAD
force-pushed
the
fix/pino-avoid-mutating-options
branch
from
b0a3067 to
777f850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids mutating user-provided options when creating multiple Pino
logger instances with the same configuration object.
Previously, reusing the same options object across multiple
pino(options)calls could lead to mixin wrappers being stacked, since the options reference
was shared. This patch defensively clones the options argument before passing
it to
pino(), preventing unintended side effects.A regression test has been added to ensure that reusing the same options object
does not cause errors or recursive mixin behavior.
Fixes #2024
Note: On Windows,
nx test instrumentation-pinofails locally due to Mocha globquoting (
'test/**/*.test.ts'). Tests pass in CI (Linux), which is the supportedenvironment for this repository.