feat: add ShouldStartFilter to control span creation in Instrumenter#15495
Open
steverao wants to merge 5 commits intoopen-telemetry:mainfrom
Open
feat: add ShouldStartFilter to control span creation in Instrumenter#15495steverao wants to merge 5 commits intoopen-telemetry:mainfrom
steverao wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
steverao
commented
Dec 3, 2025
| *** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder (not serializable) | ||
| === CLASS FILE FORMAT VERSION: 52.0 <- 52.0 | ||
| GENERIC TEMPLATES: === REQUEST:java.lang.Object, === RESPONSE:java.lang.Object | ||
| +++ NEW METHOD: PUBLIC(+) io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder<REQUEST,RESPONSE> addShouldStartFilter(io.opentelemetry.instrumentation.api.internal.InternalShouldStartFilter<? super REQUEST>) |
Contributor
Author
There was a problem hiding this comment.
For this extension, I added new method addShouldStartFilter in InstrumenterBuilder. Do you have any comment or guidance about this point?
steverao
commented
Dec 11, 2025
| final List<AttributesExtractor<? super REQUEST, ? super RESPONSE>> | ||
| operationListenerAttributesExtractors = new ArrayList<>(); | ||
| final List<ContextCustomizer<? super REQUEST>> contextCustomizers = new ArrayList<>(); | ||
| final List<InternalShouldStartFilter<? super REQUEST>> shouldStartFilters = new ArrayList<>(); |
Contributor
Author
There was a problem hiding this comment.
Is it set as a global filter for all instrumentations or an InstrumenterBuilder-level filter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #15477