Skip to content

Add support for the development attributes advisory parameter#8135

Merged
dashpole merged 5 commits intoopen-telemetry:mainfrom
dashpole:attributes_advisory
Apr 10, 2026
Merged

Add support for the development attributes advisory parameter#8135
dashpole merged 5 commits intoopen-telemetry:mainfrom
dashpole:attributes_advisory

Conversation

@dashpole
Copy link
Copy Markdown
Contributor

@dashpole dashpole commented Apr 3, 2026

From the spec:

Instrument advisory parameter: Attributes

Status: Development

Applies to all instrument types.

Attributes (a list of attribute keys) is
the recommended set of attribute keys to be used for the resulting metrics.

We already have WithAttributes options, so i've opted to name this WithDefaultAttributes to avoid naming collisions. We could also consider WithAttributeKeys, or WithDefaultAttributeKeys

Follows the pattern for experimental options introduced in #8111

@dashpole dashpole force-pushed the attributes_advisory branch from cefe348 to 40ed379 Compare April 3, 2026 20:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.3%. Comparing base (56cd7ab) to head (2fb77b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metric/x/options.go 0.0% 5 Missing ⚠️
sdk/metric/meter.go 97.6% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8135     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        309     310      +1     
  Lines      24238   24255     +17     
=======================================
+ Hits       19963   19975     +12     
- Misses      3898    3903      +5     
  Partials     377     377             
Files with missing lines Coverage Δ
sdk/metric/pipeline.go 90.3% <100.0%> (+<0.1%) ⬆️
sdk/metric/meter.go 92.3% <97.6%> (+0.2%) ⬆️
metric/x/options.go 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dashpole dashpole force-pushed the attributes_advisory branch 5 times, most recently from 4024a92 to 644c4c6 Compare April 6, 2026 19:19
@dashpole dashpole marked this pull request as ready for review April 6, 2026 19:20
@dashpole dashpole force-pushed the attributes_advisory branch from 6be1075 to eb6fede Compare April 9, 2026 20:19
Co-authored-by: Robert Pająk <[email protected]>
@dashpole dashpole merged commit d96b420 into open-telemetry:main Apr 10, 2026
34 checks passed
@dashpole dashpole deleted the attributes_advisory branch April 10, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants