Support http/json in otlpmetrichttp#7804
Open
petern48 wants to merge 7 commits intoopen-telemetry:mainfrom
Open
Support http/json in otlpmetrichttp#7804petern48 wants to merge 7 commits intoopen-telemetry:mainfrom
http/json in otlpmetrichttp#7804petern48 wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7804 +/- ##
=======================================
- Coverage 86.1% 85.4% -0.8%
=======================================
Files 302 302
Lines 22046 22106 +60
=======================================
- Hits 18989 18883 -106
- Misses 2676 2702 +26
- Partials 381 521 +140
🚀 New features to boost your workflow:
|
Contributor
Author
|
The The failing codecov CI makes sense to me as well. The modifications to I'm just going to leave the PR here and await feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for encoding in protojson format and make it configurable, keeping proto as the default option.
closes #7803
This is needed for the following:
open-telemetry/opentelemetry-go-contrib#6339
open-telemetry/opentelemetry-go-contrib#8399