FIX: Otlp common charlist string#961
Open
WWWcool wants to merge 5 commits intoopen-telemetry:mainfrom
Open
Conversation
Convert list values that are valid unicode charlists to `string_value` instead of `array_value` so log bodies are exported as readable text instead of byte arrays. Co-authored-by: Cursor <[email protected]>
Use pattern matching on `{ok, Bin} | error` for unicode charlist conversion to keep list handling idiomatic and explicit in Erlang.
Co-authored-by: Cursor <[email protected]>
|
Member
|
I think my idea was that you had to use binaries for strings just to not have the old issue of getting a string when you wanted a list/array. But maybe since we are dealing with lots of attributes in logs that likely don't even necessarily come from the user that isn't a good way of doing things. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
=======================================
Coverage 17.66% 17.66%
=======================================
Files 24 24
Lines 719 719
=======================================
Hits 127 127
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.