Add support for serializing KeyValue lists - WIP#7015
Draft
juliuskoval wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
Add support for serializing KeyValue lists - WIP#7015juliuskoval wants to merge 2 commits intoopen-telemetry:mainfrom
juliuskoval wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
Question: As far as I know, the spec doesn't say anything about limits to have many nested layers there can be, but shouldn't we try to guard against self-referencing IEnumerables? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7015 +/- ##
==========================================
- Coverage 88.90% 88.80% -0.10%
==========================================
Files 263 263
Lines 12424 12458 +34
==========================================
+ Hits 11045 11063 +18
- Misses 1379 1395 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
I think so, otherwise it would cause a stack overflow? Could just add a recursion limit to track such occurences. |
9a4d11f to
8d385e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec, attribute values should be
AnyValue. One of the possible values ofAnyValueisKeyValueList, which we currently aren't able to serialize properly.Changes
This PR adds support for serializing KeyValue lists to the OTLP exporter.
I haven't put a lot of effort into the Zipkin exporter since it is obsolete and I still need to properly implement this feature in the console exporter, so I'm only making this PR a draft.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes