Add ORD Overlays support for patching ORD information - #148
Open
Fannon wants to merge 2 commits into
Open
Conversation
|
swennemers
reviewed
Jun 9, 2026
| x-introduced-in-version: "1.15.0" | ||
| description: |- | ||
| ORD Overlay file for patching referenced resource definition files. | ||
| ORD Overlay file for patching ORD resources and/or referenced resource definition files. |
Member
There was a problem hiding this comment.
I don't think we should allow patching ORD resources at this place, next to the resource definitions
Suggested change
| ORD Overlay file for patching ORD resources and/or referenced resource definition files. | |
| ORD Overlay file for patching referenced resource definition files. |
swennemers
reviewed
Jun 9, 2026
| x-introduced-in-version: "1.15.0" | ||
| description: |- | ||
| ORD Overlay file for patching metadata / resource definition files. | ||
| ORD Overlay file for patching ORD resources and/or referenced resource definition files. |
swennemers
reviewed
Jun 9, 2026
Comment on lines
+40
to
+43
| Version `0.2` adds the `ordId` selector for patching ORD resource metadata directly, | ||
| and allows the document-level `target` to be omitted when all patches use `selector.ordId`. | ||
| Version `0.1` is still accepted for backward compatibility with overlays produced under | ||
| ORD 1.16.0; new overlays SHOULD use `"0.2"`. |
Member
There was a problem hiding this comment.
sure that we want the changelog in the description? do we have an alternative place for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
0.2and reintroduced theordIdselector (OverlaySelectorByOrdId).selector.ordId, the document-leveltargetMAY be omitted — each patch carries its own resource identifier and a single overlay file MAY patch multiple ORD resources at once.ordOverlayenum now accepts both"0.1"(kept for backward compatibility with overlays produced under ORD 1.16.0) and"0.2"(new overlays SHOULD use"0.2").