btl/self: add accelerator-aware memory copy for put/get#13746
Open
Gonzalosilvalde wants to merge 1 commit intoopen-mpi:mainfrom
Open
btl/self: add accelerator-aware memory copy for put/get#13746Gonzalosilvalde wants to merge 1 commit intoopen-mpi:mainfrom
Gonzalosilvalde wants to merge 1 commit intoopen-mpi:mainfrom
Conversation
bosilca
reviewed
Apr 3, 2026
opal/mca/btl/self/btl_self.c
Outdated
| uint64_t dst_flags, src_flags; | ||
| int rc; | ||
|
|
||
| if (NULL == opal_accelerator.check_addr) { |
Member
There was a problem hiding this comment.
This cannot be NULL, in the worst case the NULL accelerator module is present with a backend function.
The btl/self component was not accelerator aware. Send-to-self operations involving GPU memory would copy data through the host instead of performing a direct device memory copy. Add mca_btl_self_memcpy() which checks whether src/dst buffers reside in accelerator memory via opal_accelerator.check_addr() and dispatches to opal_accelerator.mem_copy() accordingly, falling back to memcpy() when both buffers are in host memory. Signed-off-by: Gonzalosilvalde <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The btl/self component was not accelerator aware. Send-to-self operations involving GPU memory would copy data through the host instead of performing a direct device memory copy.
Add mca_btl_self_memcpy() which checks whether src/dst buffers reside in accelerator memory via opal_accelerator.check_addr() and dispatches to opal_accelerator.mem_copy() accordingly, falling back to memcpy() when both buffers are in host memory.
Fixes #12230