Skip to content

make instance name dynamic array #13735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dupratj wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

make instance name dynamic array #13735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ompi/errhandler/errhandler_predefined.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* Copyright (c) 2018 Amazon.com, Inc. or its affiliates. All Rights reserved.
* Copyright (c) 2018-2021 Triad National Security, LLC. All rights
* reserved.
* Copyright (c) 2026 BULL S.A.S. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down
9 changes: 8 additions & 1 deletion ompi/instance/instance.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Copyright (c) 2023 Jeffrey M. Squyres. All rights reserved.
* Copyright (c) 2024 NVIDIA Corporation. All rights reserved.
* Copyright (c) 2026 Nanook Consulting All rights reserved.
* Copyright (c) 2026 BUL S.A.S. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -108,8 +109,12 @@ static opal_finalize_domain_t ompi_instance_common_domain;
static void ompi_instance_construct (ompi_instance_t *instance)
{
instance->i_f_to_c_index = opal_pointer_array_add (&ompi_instance_f_to_c_table, instance);
instance->i_name = (char*) malloc (OPAL_MAX_OBJECT_NAME);
if (NULL == instance->i_name) {
return;
}
instance->i_name[0] = '\0';
instance->i_flags = 0;
instance->i_flags = 0;
instance->i_keyhash = NULL;
OBJ_CONSTRUCT(&instance->s_lock, opal_mutex_t);
instance->errhandler_type = OMPI_ERRHANDLER_TYPE_INSTANCE;
Expand All @@ -118,6 +123,8 @@ static void ompi_instance_construct (ompi_instance_t *instance)

static void ompi_instance_destruct(ompi_instance_t *instance)
{
free(instance->i_name);
instance->i_name = NULL;
OBJ_DESTRUCT(&instance->s_lock);
}

Expand Down
2 changes: 1 addition & 1 deletion ompi/instance/instance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct ompi_instance_t {
opal_infosubscriber_t super;
opal_mutex_t s_lock;
int i_thread_level;
char i_name[MPI_MAX_OBJECT_NAME];
char *i_name;
uint32_t i_flags;

/* Attributes */
Expand Down