compatible with New Config in mmpretrain.apis.get_model - #1868
Open
youqingxiaozhua wants to merge 2 commits into
Open
compatible with New Config in mmpretrain.apis.get_model#1868youqingxiaozhua wants to merge 2 commits into
mmpretrain.apis.get_model#1868youqingxiaozhua wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
===========================================
- Coverage 85.22% 62.77% -22.46%
===========================================
Files 229 375 +146
Lines 17243 27180 +9937
Branches 2707 4310 +1603
===========================================
+ Hits 14696 17062 +2366
- Misses 2046 9496 +7450
- Partials 501 622 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the new config setting, the
typevalue will change fromstrtoclass. Modify theget_modelfunction to adoptclassvalue.Modification
If the
typevalue in the config is a class, use the class directly.BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
No.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
No.
Checklist
Before PR:
After PR: