Skip to content

ci: Upload MSIX when RC application created#3478

Draft
ivanzati wants to merge 5 commits intomainfrom
ivanzati/msix-upload-when-rc-app-created
Draft

ci: Upload MSIX when RC application created#3478
ivanzati wants to merge 5 commits intomainfrom
ivanzati/msix-upload-when-rc-app-created

Conversation

@ivanzati
Copy link
Copy Markdown
Contributor

📝 Description

Call workflow to upload MSIX as artifact when RC Application is published

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI review requested due to automatic review settings March 27, 2026 18:25
@ivanzati ivanzati requested a review from a team as a code owner March 27, 2026 18:25
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 18:25 — with GitHub Actions Inactive
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 18:25 — with GitHub Actions Inactive
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 18:25 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI/CD workflows so that when an RC application is published, the Tauri Windows build workflow is invoked as a reusable workflow and the produced MSIX can be uploaded as an artifact with an RC-based filename.

Changes:

  • Add workflow_call support to the Tauri build workflow with inputs for rc_version and accelerator.
  • Adjust MSIX filename logic to use the RC version when the workflow is called.
  • Trigger the Tauri build workflow from the RC publish workflow using a matrix over accelerators and pass signing secrets.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/tauri-build.yaml Adds workflow_call inputs and RC-based MSIX naming for reusable workflow invocation.
.github/workflows/publish-rc-app.yml Calls the reusable Tauri build workflow after publishing the RC container image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/tauri-build.yaml
Comment thread .github/workflows/tauri-build.yaml
Comment on lines +230 to +237
strategy:
fail-fast: false
matrix:
accelerator: [cpu, xpu, cu124]
uses: ./.github/workflows/tauri-build.yaml
with:
rc_version: ${{ needs.validate.outputs.rc_version }}
accelerator: ${{ matrix.accelerator }}
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger-tauri-build uses a matrix over accelerator while the called tauri-build.yaml workflow also currently expands its own accelerator matrix for non-workflow_dispatch events. Unless the called workflow is updated to honor workflow_call inputs, this job will trigger redundant builds (effectively 3x) and may upload artifacts with the same name multiple times in a single run. Either remove the caller matrix and let the called workflow build all accelerators once, or make the called workflow build only the passed accelerator for workflow_call.

Suggested change
strategy:
fail-fast: false
matrix:
accelerator: [cpu, xpu, cu124]
uses: ./.github/workflows/tauri-build.yaml
with:
rc_version: ${{ needs.validate.outputs.rc_version }}
accelerator: ${{ matrix.accelerator }}
uses: ./.github/workflows/tauri-build.yaml
with:
rc_version: ${{ needs.validate.outputs.rc_version }}

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/publish-rc-app.yml
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

Docker Image Sizes

CPU

Image Size
anomalib-studio-cpu:pr-3478 1.01G
anomalib-studio-cpu:sha-31c4559 1.01G

CUDA

Image Size
anomalib-studio-cuda:pr-3478 4.74G
anomalib-studio-cuda:sha-31c4559 4.74G

XPU

Image Size
anomalib-studio-xpu:pr-3478 3.05G
anomalib-studio-xpu:sha-31c4559 3.05G

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ivan Zakharov <ivan.zakharov@intel.com>
Copilot AI review requested due to automatic review settings March 27, 2026 19:21
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 19:21 — with GitHub Actions Inactive
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 19:21 — with GitHub Actions Inactive
@ivanzati ivanzati temporarily deployed to windows-msix-signing March 27, 2026 19:21 — with GitHub Actions Inactive
@ivanzati ivanzati marked this pull request as draft March 27, 2026 19:23
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Ivan Zakharov <ivan.zakharov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants