Conversation
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/CD workflows so that when an RC application is published, the Tauri Windows build workflow is invoked as a reusable workflow and the produced MSIX can be uploaded as an artifact with an RC-based filename.
Changes:
- Add
workflow_callsupport to the Tauri build workflow with inputs forrc_versionandaccelerator. - Adjust MSIX filename logic to use the RC version when the workflow is called.
- Trigger the Tauri build workflow from the RC publish workflow using a matrix over accelerators and pass signing secrets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/tauri-build.yaml | Adds workflow_call inputs and RC-based MSIX naming for reusable workflow invocation. |
| .github/workflows/publish-rc-app.yml | Calls the reusable Tauri build workflow after publishing the RC container image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| accelerator: [cpu, xpu, cu124] | ||
| uses: ./.github/workflows/tauri-build.yaml | ||
| with: | ||
| rc_version: ${{ needs.validate.outputs.rc_version }} | ||
| accelerator: ${{ matrix.accelerator }} |
There was a problem hiding this comment.
trigger-tauri-build uses a matrix over accelerator while the called tauri-build.yaml workflow also currently expands its own accelerator matrix for non-workflow_dispatch events. Unless the called workflow is updated to honor workflow_call inputs, this job will trigger redundant builds (effectively 3x) and may upload artifacts with the same name multiple times in a single run. Either remove the caller matrix and let the called workflow build all accelerators once, or make the called workflow build only the passed accelerator for workflow_call.
| strategy: | |
| fail-fast: false | |
| matrix: | |
| accelerator: [cpu, xpu, cu124] | |
| uses: ./.github/workflows/tauri-build.yaml | |
| with: | |
| rc_version: ${{ needs.validate.outputs.rc_version }} | |
| accelerator: ${{ matrix.accelerator }} | |
| uses: ./.github/workflows/tauri-build.yaml | |
| with: | |
| rc_version: ${{ needs.validate.outputs.rc_version }} |
Docker Image SizesCPU
CUDA
XPU
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ivan Zakharov <ivan.zakharov@intel.com>
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Ivan Zakharov <ivan.zakharov@intel.com>
📝 Description
Call workflow to upload MSIX as artifact when RC Application is published
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.