Skip to content

chore: add copyright notice to all files#234

Merged
mschoettle merged 11 commits intomainfrom
add-license
Mar 20, 2025
Merged

chore: add copyright notice to all files#234
mschoettle merged 11 commits intomainfrom
add-license

Conversation

@mschoettle
Copy link
Member

No description provided.

@mschoettle mschoettle changed the title chore: add reuse workflow chore: add copyright notice to all files Feb 19, 2025
Copy link

@AntonGladyr AntonGladyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have just one LICENSE file in the root of the repository where we would state that the repository has two different licenses. Or at least we should mention it in the README.

@mschoettle
Copy link
Member Author

Would it make sense to have just one LICENSE file in the root of the repository where we would state that the repository has two different licenses. Or at least we should mention it in the README.

True. I added them only for GitHub, so that it shows up on the repo. But we could simply state it at the bottom of the README. Or, add a LICENSE file where we say that the repo uses the REUSE specification and so on...

@mschoettle mschoettle self-assigned this Mar 3, 2025
@AntonGladyr
Copy link

Would it make sense to have just one LICENSE file in the root of the repository where we would state that the repository has two different licenses. Or at least we should mention it in the README.

True. I added them only for GitHub, so that it shows up on the repo. But we could simply state it at the bottom of the README. Or, add a LICENSE file where we say that the repo uses the REUSE specification and so on...

Btw, the licenses are not shown correctly in the repo - it should appear at the About summary, and also the names of the licenses should be included at the top of the README (currently it's just LICENSE instead of the license name; see nextcloud for example: https://github.com/nextcloud/server)

@mschoettle
Copy link
Member Author

Btw, the licenses are not shown correctly in the repo - it should appear at the About summary, and also the names of the licenses should be included at the top of the README (currently it's just LICENSE instead of the license name; see nextcloud for example: https://github.com/nextcloud/server)

Good catch! It depends what we want.

Option 1:

We put the AGPL license in LICENSE. A custom text (similar to what Nextcloud has) we put into LICENSE-README.

Option 2:

We just put custom text in LICENSE.

@AntonGladyr
Copy link

Good catch! It depends what we want.

Option 1:

We put the AGPL license in LICENSE. A custom text (similar to what Nextcloud has) we put into LICENSE-README.

Option 2:

We just put custom text in LICENSE.

I like more option two since all licenses will be listed in one file. Also, we won't have Unknown licenses found like in nextcloud repo.

In fontawesome repo they just have one LICENSE file with custom text: https://github.com/FortAwesome/Font-Awesome#License-1-ov-file

@mschoettle mschoettle requested a review from AntonGladyr March 13, 2025 16:01
@mschoettle
Copy link
Member Author

I changed to a custom LICENSE file and also brought the branch up to date.

@AntonGladyr
Copy link

LGTM!

@mschoettle mschoettle merged commit 245349f into main Mar 20, 2025
5 checks passed
@mschoettle mschoettle deleted the add-license branch March 20, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants