Open
Conversation
Member
|
@xadupre could you have a look at it? |
sharktide
reviewed
Jul 20, 2025
tf2onnx/convert.py
Outdated
Comment on lines
507
to
508
|
|
||
| #print(model_proto) |
Contributor
There was a problem hiding this comment.
Suggested change
| #print(model_proto) |
Might be better to remove the debug statement and extra newlines
Author
|
Hello, I just wanted to ask whether the pull request is still under review or if there is no further interest in it. If it is still being considered, is there anything I should change to make it suitable for integration? |
Contributor
I am interested, and I think this would be a useful feature, however I feel that I am not the right reviewer for this PR |
039c046 to
47f8339
Compare
Signed-off-by: nfirle <[email protected]>
Signed-off-by: nfirle <[email protected]>
47f8339 to
7884e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Keras 3 in the
from_kerasconversion function. Keras 3 introduced several breaking changes in model serialization and internal APIs, which caused the existing conversion logic to fail. This update ensures compatibility with the new format.Changes
from_keras3that handles models created with Keras 3.from_kerasto detect the Keras version and delegate tofrom_keras3when necessary.from_keras3function is designed to also work with older Keras versions, but for full backward compatibility, the originalfrom_keraslogic is preserved.