Conversation
xadupre
approved these changes
Feb 4, 2025
Collaborator
|
We need to enable CI on 3.10-3.12. |
Author
|
@xadupre have a glace? |
Collaborator
|
I started to look into this in #2385 but I realized it would take much more time than I anticipated since 2.18 seems to be very different from the previous versions. Some apis tensorflow-onnx rely on don't work anymore. But maybe we can do that step by step. Your PR seems closer to completion than mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great project!
When attempting to pull this in, under python 3.12, I noticed that the satsolver failed to resolve (I'm using uv!) as there's no trove for python 3.12.
I'm positive there are changes other than this that are necessary, but I wanted to at least help this along, as python 3.12 is the default install on several Linux distributions.
How else can I help?