This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
- Coverage 37.36% 37.23% -0.13%
==========================================
Files 298 294 -4
Lines 12283 12256 -27
Branches 1612 1609 -3
==========================================
- Hits 4589 4563 -26
Misses 7444 7444
+ Partials 250 249 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the
reduxfolder into a separatenpmpackage. There are several pieces of functionality that depend on creating a redux store (and we use theRequestAnimationFrameBatcherin all of them, for performance). Since this is now a separate package, other features that need a redux store could be factored out into a module or a plugin, and just pick up a dependency on this module.