feat(parsing): update list of reserved usernames - #4
Open
shiftinv wants to merge 4 commits into
Open
Conversation
shiftinv
force-pushed
the
feat/update-denied-usernames
branch
from
November 27, 2025 20:00
7b2bbeb to
578e95a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the list of reserved/disallowed usernames to a separate module (this could've been a json file but bundling static resources is more work :3 ), and adds like ~325 new ones.
It's missing a few (like
/models), which are somehow not present in https://github.com/apple-app-site-association (where this was pulled from), but are part of the denylist in the ghes source. We could merge the two lists to hopefully have a complete set of unresolvable usernames?